HyukjinKwon commented on code in PR #49015:
URL: https://github.com/apache/spark/pull/49015#discussion_r1863119559
##########
python/pyspark/sql/connect/functions/builtin.py:
##########
@@ -59,6 +59,18 @@
UnresolvedNamedLambdaVariable,
CallFunction,
)
+
+# import the hash functions
+from pyspark.sql.connect.functions._hash_funcs import ( # noqa: F401
+ crc32,
+ hash,
+ md5,
+ sha,
+ sha1,
+ sha2,
+ xxhash64,
Review Comment:
if we're going to do this, I think it's better to import with a star, and
have `__all__` at `functions/__init__.py`, and rename `_hash_funcs.py` ->
`hash_funcs.py` as the namespace will be hidden anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
