HyukjinKwon commented on code in PR #49021:
URL: https://github.com/apache/spark/pull/49021#discussion_r1866815413
##########
sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java:
##########
@@ -69,14 +69,14 @@ public abstract class ColumnVector implements AutoCloseable
{
public abstract void close();
/**
- * Cleans up memory for this column vector if it's not writable. The column
vector is not usable
- * after this.
+ * Cleans up memory for this column vector if it's resources are freeable
between batches.
+ * The column vector is not usable after this.
*
- * If this is a writable column vector, it is a no-op.
+ * If this is a writable column vector or constant column vector, it is a
no-op.
*/
- public void closeIfNotWritable() {
- // By default, we just call close() for all column vectors. If a column
vector is writable, it
- // should override this method and do nothing.
+ public void closeIfFreeable() {
Review Comment:
ah okie dokie then should be fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
