siying commented on code in PR #48355:
URL: https://github.com/apache/spark/pull/48355#discussion_r1866798871
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -316,20 +346,45 @@ class RocksDBFileManager(
}
}
+ // Get latest snapshot version <= version
+ def getLatestSnapshotVersionAndUniqueId(
+ version: Long, checkpointUniqueId: Option[String] = None): Array[(Long,
Option[String])] = {
Review Comment:
In the case of version = 0, it is clearer to me if the return value is
Option[Array[String]]. If it is None, it means no snapshot is found. It is
non-intuitive to say we found a verison 0, but it has no checkpoint ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
