stefankandic commented on code in PR #49043:
URL: https://github.com/apache/spark/pull/49043#discussion_r1867711852
##########
sql/api/src/main/scala/org/apache/spark/sql/types/UpCastRule.scala:
##########
@@ -40,8 +40,8 @@ private[sql] object UpCastRule {
case (DateType, TimestampNTZType) => true
case (TimestampNTZType, TimestampType) => true
case (TimestampType, TimestampNTZType) => true
- case (_: AtomicType, StringType) => true
- case (_: CalendarIntervalType, StringType) => true
+ case (_: AtomicType, _: StringType) => true
Review Comment:
can we add some tests for upcast
[here](https://github.com/apache/spark/blob/400a8d3797bdcc9183576e66e84163e4dc00a662/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuiteBase.scala#L659)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
