HyukjinKwon commented on code in PR #49054:
URL: https://github.com/apache/spark/pull/49054#discussion_r1868835364
##########
python/pyspark/sql/classic/column.py:
##########
@@ -175,12 +174,16 @@ def _reverse_op(
return Column(jc)
-@with_origin_to_class
class Column(ParentColumn):
def __new__(
cls,
jc: "JavaObject",
) -> "Column":
+ from pyspark.errors.utils import with_origin_to_class
+
+ if not hasattr(cls, "_with_origin_applied"):
+ cls = with_origin_to_class(cls)
Review Comment:
I think the overhead of doing this is actually non trivial. Previously, we
wrapped them once but now we do this everytime we create the instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
