pan3793 commented on PR #48941:
URL: https://github.com/apache/spark/pull/48941#issuecomment-2518359114

   > spark.executor.extraJavaOptions could potentially allow the execution of 
unintended shell commands
   
   I think the assumption violates the original intention of JVM options, it is 
clearly documented in [Oracle Java 8 
docs](https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/clopts001.html)
   
   > The script or command is specified using the `-XX:OnError=string` 
command-line option, where `string` is a single command, or a list of commands 
separated by semicolons.
   
   with an example
   
   > ```
   > java -XX:OnError="cat hs_err_pid%p.log | mail [email protected]" MyApp
   > ```
   it won't work after this patch.
   
   I think the change fixes nothing but may break some normal use cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to