HeartSaVioR commented on code in PR #49065:
URL: https://github.com/apache/spark/pull/49065#discussion_r1870558368
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -2011,6 +2011,9 @@ case class Deduplicate(
}
case class DeduplicateWithinWatermark(keys: Seq[Attribute], child:
LogicalPlan) extends UnaryNode {
+ // Ensure that references include watermarking columns so they are not
pruned away.
Review Comment:
nit: Watermark is a concept; it is more proper to call the column as "event
time" column, as the column represents the event time of the input.
Title, and this line, and test name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
