eejbyfeldt commented on code in PR #47164: URL: https://github.com/apache/spark/pull/47164#discussion_r1875757158
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala: ########## @@ -58,6 +58,8 @@ case class ScalaUDF( override lazy val deterministic: Boolean = udfDeterministic && children.forall(_.deterministic) + override lazy val foldable: Boolean = deterministic && children.forall(_.foldable) Review Comment: @HyukjinKwon any chance we could modify this change to make it acceptable or should it just be abandoned? I also notice that we will attempt to execute expressions and therefore UDFs as part of `EliminateOuterJoins`. There errors are ignored. We could extend the `ConstantFolding` rule to the same, ignore errors from expressions containing UDFs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
