hvanhovell commented on code in PR #48791: URL: https://github.com/apache/spark/pull/48791#discussion_r1876717230
########## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLCache.scala: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.connect.ml + +import java.util.UUID +import java.util.concurrent.ConcurrentHashMap + +import org.apache.spark.internal.Logging + +/** + * MLCache is for caching ML objects, typically for models and summaries evaluated by a model. + */ +private[connect] class MLCache extends Logging { + private val cachedModel: ConcurrentHashMap[String, Object] = + new ConcurrentHashMap[String, Object]() + + /** + * Cache an object into a map of MLCache, and return its key + * @param obj + * the object to be cached + * @return + * the key + */ + def register(obj: Object): String = { + val objectId = UUID.randomUUID().toString.takeRight(12) Review Comment: Why only 12 characters? This is 44 bits of entropy (11 characters, 1 character is constant..., 4 bits per character)... Is that enough to avoid collisions? An alternative would be to generate a predictable Id. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
