yaooqinn commented on code in PR #48986:
URL: https://github.com/apache/spark/pull/48986#discussion_r1877183589
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -1130,10 +1133,6 @@ private[hive] object HiveClientImpl extends Logging {
Option(hc.getComment).map(field.withComment).getOrElse(field)
}
- private def verifyColumnDataType(schema: StructType): Unit = {
Review Comment:
OK, let me state it again. the Hive parser (in HMS) and the Spark SQL parser
do the nested struct type parsing in completely opposite ways for quoting.
It's nonsense here to use the Spark SQL parser to verify schemas produced by
itself but claim it as an HIVE_TYPE error.
For the callers, like create-table, alter-table commands that rely on the
errors to re-store schemas into the spark properties, are still work correctly.
Or perhaps, more correctly with the actual hive error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
