chenhao-db commented on code in PR #48851: URL: https://github.com/apache/spark/pull/48851#discussion_r1878414601
########## common/variant/src/main/java/org/apache/spark/types/variant/ShreddingUtils.java: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.types.variant; + +import java.math.BigDecimal; +import java.util.ArrayList; + +import static org.apache.spark.types.variant.VariantUtil.*; + +public class ShreddingUtils { + // Interface to read from a shredded result. It essentially has the same interface and semantics + // as Spark's `SpecializedGetters`, but we need a new interface to avoid the dependency. + public interface ShreddedRow { + boolean isNullAt(int ordinal); + boolean getBoolean(int ordinal); + byte getByte(int ordinal); + short getShort(int ordinal); + int getInt(int ordinal); + long getLong(int ordinal); + float getFloat(int ordinal); + double getDouble(int ordinal); + BigDecimal getDecimal(int ordinal, int precision, int scale); + String getString(int ordinal); + byte[] getBinary(int ordinal); + ShreddedRow getStruct(int ordinal, int numFields); + ShreddedRow getArray(int ordinal); Review Comment: We don't need `getMap` because the shredding schema never contains map. The `ShreddedRow` returned by `getArray` has the same functionality as `ArrayData` (in `SparkShreddedRow`, it wraps an `ArrayData`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
