panbingkun commented on code in PR #49159: URL: https://github.com/apache/spark/pull/49159#discussion_r1881938924
########## resource-managers/kubernetes/core/src/main/java/org/apache/spark/deploy/k8s/SparkVertxHttpClientFactory.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.deploy.k8s; + +import io.fabric8.kubernetes.client.vertx.VertxHttpClientBuilder; +import io.fabric8.kubernetes.client.vertx.VertxHttpClientFactory; +import io.vertx.core.Vertx; +import io.vertx.core.VertxOptions; +import io.vertx.core.file.FileSystemOptions; + +public class SparkVertxHttpClientFactory extends VertxHttpClientFactory { + + private final Vertx vertx = createVertxInstance(); + + @Override + public VertxHttpClientBuilder<VertxHttpClientFactory> newBuilder() { + return new VertxHttpClientBuilder<>(this, this.vertx); + } + + private static synchronized Vertx createVertxInstance() { + String originalValue = System.getProperty("vertx.disableDnsResolver"); + + Vertx vertx; + try { + System.setProperty("vertx.disableDnsResolver", "true"); + vertx = Vertx.vertx((new VertxOptions()) + .setUseDaemonThread(true) Review Comment: - Because some threads (`vertx-blocked-thread-checker`, `vert.x-eventloop-thread-0`, `vert.x-internal-blocking-0`, `vert.x-acceptor-thread-0`) in `vert.x` are `daemon=false`, i When using `val pb = new ProcessBuilder().command(fullCommand: _*)` in testing for submitting a Spark application, `the process` did not end when the application had `successfully` ended, causing the test to hang indefinitely. - Therefore, the following improvements were made based on `VertxHttpClientFactory`, setting `useDaemonThread` as `true`. https://github.com/fabric8io/kubernetes-client/blob/main/httpclient-vertx/src/main/java/io/fabric8/kubernetes/client/vertx/VertxHttpClientFactory.java#L45-L49 <img width="970" alt="image" src="https://github.com/user-attachments/assets/68bf4c01-87fd-4c32-aed0-259da28df4ed"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
