vladanvasi-db commented on code in PR #49148:
URL: https://github.com/apache/spark/pull/49148#discussion_r1883521354
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1672,13 +1672,18 @@ class Dataset[T] private[sql](
/** @inheritdoc */
override def toJSON: Dataset[String] = {
+ toJSON(Map.empty[String, String])
+ }
+
+ /** @inheritdoc */
+ override def toJSON(jsonOptions: Map[String, String]): Dataset[String] = {
Review Comment:
Yes, actually we can bypass it using this one properly, however, do you
still think it is worth to extend the `toJSON` API? In my opinion, a lot of
users will not figure out this workaround when trying to specify options for
`toJSON` in a `DataSet`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
