cloud-fan commented on code in PR #48895:
URL: https://github.com/apache/spark/pull/48895#discussion_r1884257545
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ReplaceHashWithSortAgg.scala:
##########
@@ -75,6 +75,7 @@ object ReplaceHashWithSortAgg extends Rule[SparkPlan] {
partialAgg.child.outputOrdering,
sortAgg.requiredChildOrdering.head)) {
sortAgg.copy(
aggregateExpressions =
sortAgg.aggregateExpressions.map(_.copy(mode = Complete)),
+ initialInputBufferOffset = 0,
Review Comment:
Does it cause any issues? If not why do we bother?
We need to carefully review the related source code to make sure this change
is safe, and it seems not worthwhile if it's for no good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
