panbingkun commented on PR #49184: URL: https://github.com/apache/spark/pull/49184#issuecomment-2542523885
LGTM, +1. Additionally, there is another `GetJsonObjectEvaluator`, and I want to move it to `JsonExpressionEvalUtils.scala`, but I would like to do so after the completion of this PR for https://github.com/apache/spark/pull/48908, so that `GetJsonObject` and `JsonTuple` can share the `SharedFactory` in the file `JsonExpressionEvalUtils.scala` (The class `SharedFactory` access restrictions is `private[this]`). @cloud-fan Can you help review this PR https://github.com/apache/spark/pull/48908 in your free time? Thank you very much ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
