stefankandic commented on PR #49186: URL: https://github.com/apache/spark/pull/49186#issuecomment-2543097320
> > If this is really that performance critical, should we make supportsBinaryEquality a lazy val? > > Can we improve it altogether? Right now it fetches the collator object and gets one of its properties. We can simply do integer comparisons against it. How is that an improvement though? If it were a val or a lazy val it would get computed only once, and now we have to do a comparison on each call, which for the interpreted path could happen billions of times. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
