MaxGekk commented on code in PR #48440: URL: https://github.com/apache/spark/pull/48440#discussion_r1886738179
########## common/utils/src/main/scala/org/apache/spark/SparkException.scala: ########## @@ -24,20 +24,14 @@ import java.util.ConcurrentModificationException import scala.jdk.CollectionConverters._ -class SparkException( +class SparkException private( Review Comment: > My point being, this is not a backward compatible change right ? Right. > Any user code which was using this constructor will now fail to compile Sure if user's code raises `SparkException` w/ arbitrary error message, it will fail, and we force to migrate on error classes/conditions - so, the user has to migrate its code. I updated PR's description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
