miland-db commented on code in PR #49006:
URL: https://github.com/apache/spark/pull/49006#discussion_r1886897497
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala:
##########
@@ -177,12 +180,54 @@ class NoOpStatementExec extends LeafStatementExec {
* Executable nodes for nested statements within the CompoundBody.
* @param label
* Label set by user to CompoundBody or None otherwise.
+ * @param isScope
+ * Flag that indicates whether Compound Body is scope or not.
+ * @param context
+ * SqlScriptingExecutionContext keeps the execution state of current script.
*/
-class CompoundBodyExec(statements: Seq[CompoundStatementExec], label:
Option[String] = None)
+class CompoundBodyExec(
+ statements: Seq[CompoundStatementExec],
+ label: Option[String] = None,
+ isScope: Boolean,
+ context: SqlScriptingExecutionContext)
extends NonLeafStatementExec {
+ private object ScopeStatus extends Enumeration {
+ type ScopeStatus = Value
+ val NOT_ENTERED, INSIDE, EXITED = Value
+ }
+
private var localIterator = statements.iterator
private var curr = if (localIterator.hasNext) Some(localIterator.next())
else None
+ private var scopeStatus = ScopeStatus.NOT_ENTERED
+
+ /**
+ * Enter scope represented by this compound statement.
+ *
+ * This operation needs to be idempotent because it is called multiple times
during
+ * iteration, but it should be executed only once when compound body that
represent
+ * scope is encountered for the first time.
+ */
+ def enterScope(): Unit = {
+ // This check makes this operation idempotent.
+ if (isScope && scopeStatus == ScopeStatus.NOT_ENTERED) {
+ scopeStatus = ScopeStatus.INSIDE
+ context.enterScope(label.get)
Review Comment:
Yes, only labeled statements can actually be scope, but not all labeled
statements are scope. Only `CompoundBody` can be scope.
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionContext.scala:
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.scripting
+
+import scala.collection.mutable.ListBuffer
+
+import org.apache.spark.SparkException
+
+/**
+ * SQL scripting execution context - keeps track of the current execution
state.
+ */
+class SqlScriptingExecutionContext {
+ // List of frames that are currently active.
+ val frames: ListBuffer[SqlScriptingExecutionFrame] = ListBuffer.empty
Review Comment:
That is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
