dongjoon-hyun commented on code in PR #49046:
URL: https://github.com/apache/spark/pull/49046#discussion_r1887169133
##########
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala:
##########
@@ -85,6 +85,9 @@ private[spark] class IndexShuffleBlockResolver(
private val remoteShuffleMaxDisk: Option[Long] =
conf.get(config.STORAGE_DECOMMISSION_SHUFFLE_MAX_DISK_SIZE)
+ private val checksumEnabled = conf.get(config.SHUFFLE_CHECKSUM_ENABLED)
+ private lazy val algorithm = conf.get(config.SHUFFLE_CHECKSUM_ALGORITHM)
Review Comment:
`lazy` is used because `algorithm` is not used when checksum is disabled.
Do you mean `algorithm` variable is used somewhere outside `checksumEnabled`
guard? Or, simply, it's cheap operation which we don't need to put `lazy`
overhead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
