cloud-fan commented on code in PR #49212:
URL: https://github.com/apache/spark/pull/49212#discussion_r1889803871
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala:
##########
@@ -112,7 +112,10 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
* A BitSet of tree patterns for this TreeNode and its subtree. If this
TreeNode and its
* subtree contains a pattern `P`, the corresponding bit for `P.id` is set
in this BitSet.
*/
- override lazy val treePatternBits: BitSet = getDefaultTreePatternBits
+ override def treePatternBits: BitSet = _treePatternBits.apply()
Review Comment:
I don't think this change helps, as all overides are still using `lazy val`.
Since the access of `treePatternBits` is very self-contained (does not
access other fields that may be locked), I think it's fine to leave it using
`lazy val`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
