cloud-fan commented on code in PR #49239: URL: https://github.com/apache/spark/pull/49239#discussion_r1891062013
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala: ########## @@ -323,6 +321,12 @@ case class VariantGet( override def withTimeZone(timeZoneId: String): VariantGet = copy(timeZoneId = Option(timeZoneId)) } +// Several parameters used by `VariantGet.cast`. Packed together to simplify parameter passing. +case class VariantCastArgs( + failOnError: Boolean, + zoneStr: Option[String], Review Comment: why do we need the original timezone string if we already have the ZoneId? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
