zml1206 commented on PR #49202: URL: https://github.com/apache/spark/pull/49202#issuecomment-2553324209
> Why do we care about common expressions in the original predicate? This is an optimization opportunity but what we should focus on is to avoid perf regression when pushing filter through project that duplicate expensive expressions. > > Maybe we should discuss this with a concrete example. As the ut in pr, I hope that the common expression will only be calculated only once. `_common_expr_0` finally used in two Filters and `as e`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
