jabbaugh commented on code in PR #49233:
URL: https://github.com/apache/spark/pull/49233#discussion_r1893159773
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala:
##########
@@ -86,7 +86,7 @@ class CSVFileFormat extends TextBasedFileFormat with
DataSourceRegister {
}
override def getFileExtension(context: TaskAttemptContext): String = {
- ".csv" + CodecStreams.getCompressionExtension(context)
+ "." + csvOptions.fileExtension +
CodecStreams.getCompressionExtension(context)
Review Comment:
That seems reasonable to me. I can add a check that limits the file
extension to three characters that are limited to a-z. If other characters are
found we can throw an exception stating the limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
