cloud-fan commented on code in PR #49202:
URL: https://github.com/apache/spark/pull/49202#discussion_r1893695012
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1831,8 +1838,8 @@ object PushPredicateThroughNonJoin extends
Rule[LogicalPlan] with PredicateHelpe
}
if (pushDown.nonEmpty) {
- val pushDownPredicate = pushDown.reduce(And)
Review Comment:
e.g. for `a * a > 0 AND a + a > 0` and `a` is a large expression, we first
push down `With(large_expr AS a, a * a > 0 AND a + a > 0)`, when we need to
split it again later, we turn it into `With(large_expr AS a, a * a > 0) AND
With(large_expr AS a, a + a > 0)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
