cloud-fan commented on code in PR #49202:
URL: https://github.com/apache/spark/pull/49202#discussion_r1893731723
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1831,8 +1838,8 @@ object PushPredicateThroughNonJoin extends
Rule[LogicalPlan] with PredicateHelpe
}
if (pushDown.nonEmpty) {
- val pushDownPredicate = pushDown.reduce(And)
Review Comment:
> In this follow-up, we can merge the with expression before rewriteWith.
This will not affect the push down.
It's better to not duplicate expressions in the first place. Creating a huge
plan tree is harmful to the optimizer/planner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
