cashmand commented on code in PR #49263:
URL: https://github.com/apache/spark/pull/49263#discussion_r1895821471


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala:
##########
@@ -390,6 +394,11 @@ object ParquetReadSupport extends Logging {
       .named(parquetRecord.getName)
   }
 
+  private def clipVariantSchema(parquetType: GroupType, variantStruct: 
StructType): GroupType = {
+    // TODO(SHREDDING): clip `parquetType` to retain the necessary columns.

Review Comment:
   I don't think it requires a new Parquet version - it should be possible to 
clip it in 
`sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala`
 in the same way that unused struct fields are clipped. The logic of deciding 
which fields can be clipped is more complicated, though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to