xupefei opened a new pull request, #49274: URL: https://github.com/apache/spark/pull/49274
### What changes were proposed in this pull request? This PR introduces a new Protobuf field `is_internal` to `UnresolvedFunction` message. This field is used to carry the info on whether an `UnresolvedFunction` is calling an internal function (using the `Column#internalFn` API), so that the Connect server could act appropriately: - If `true`, then (inside Catalyst) mark the function as internal. - If `false`, then mark the function as external (public or user-defined). - (Current behaviour) If not set, then look it up in the internal registry: mark as "internal" if found, "external" otherwise. ### Why are the changes needed? Tidy up the code and make our first-party Connect client adhere to the best practices. ### Does this PR introduce _any_ user-facing change? Nope. ### How was this patch tested? New test is added. ### Was this patch authored or co-authored using generative AI tooling? Copilot helped generate protobuf comments and repeated test codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
