cloud-fan commented on code in PR #49202:
URL: https://github.com/apache/spark/pull/49202#discussion_r1896520694
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1831,8 +1841,8 @@ object PushPredicateThroughNonJoin extends
Rule[LogicalPlan] with PredicateHelpe
}
if (pushDown.nonEmpty) {
- val pushDownPredicate = pushDown.reduce(And)
- val replaced = replaceAlias(pushDownPredicate, aliasMap)
+ val replacedByWith = rewriteConditionByWith(pushDown.reduce(And),
aliasMap)
+ val replaced = replaceAlias(replacedByWith, aliasMap)
Review Comment:
doesn't `rewriteConditionByWith` already replace the aliases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
