LuciferYang commented on PR #49261:
URL: https://github.com/apache/spark/pull/49261#issuecomment-2561936363
> Can we have a micro benchmark?
+1 for micro benchmark. `StringBuilder` wraps `j.l.StringBuilder`,
```
final class StringBuilder(val underlying: java.lang.StringBuilder) extends
AbstractSeq[Char]
with ReusableBuilder[Char, String]
with IndexedSeq[Char]
with IndexedSeqOps[Char, IndexedSeq, StringBuilder]
with IterableFactoryDefaults[Char, IndexedSeq]
with java.lang.CharSequence
with Serializable
```
the functions should all directly operate on the `underlying`, so I'm not
sure if this really brings a performance improvement. If it does, is this the
only place worth change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
