tedyu commented on code in PR #49268:
URL: https://github.com/apache/spark/pull/49268#discussion_r1897514857
##########
python/pyspark/sql/plot/plotly.py:
##########
@@ -48,13 +48,34 @@ def plot_pyspark(data: "DataFrame", kind: str, **kwargs:
Any) -> "Figure":
def plot_pie(data: "DataFrame", **kwargs: Any) -> "Figure":
- # TODO(SPARK-49530): Support pie subplots with plotly backend
from plotly import express
pdf = PySparkPlotAccessor.plot_data_map["pie"](data)
x = kwargs.pop("x", None)
y = kwargs.pop("y", None)
- fig = express.pie(pdf, values=y, names=x, **kwargs)
+ subplots = kwargs.pop("subplots", False)
+ if y is None and not subplots:
+ raise PySparkValueError(errorClass="UNSUPPORTED_PIE_PLOT_PARAM",
messageParameters={})
Review Comment:
It seems we can use default value of `True` for `subplots` in this case (`y
is None`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
