morvenhuang opened a new pull request, #49296: URL: https://github.com/apache/spark/pull/49296
### What changes were proposed in this pull request? To fix the compilation failure of `spark-protobuf` module when using user-defined protoc, the error is caused by `protocol-jar-maven-plugin` bug [NPE while executing plugin on unchanged proto files](https://github.com/os72/protoc-jar-maven-plugin/issues/104) ### Why are the changes needed? Before: ``` $ export SPARK_PROTOC_EXEC_PATH=/Users/foobar/dev/protoc-4.29.1/protoc $ export CONNECT_PLUGIN_EXEC_PATH=/Users/foobar/dev/protoc-gen-grpc-java-1.59.1/protoc-gen-grpc-java $ build/mvn -DskipTests clean install -pl connector/protobuf -e -am ... [ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (default) on project spark-protobuf_2.13: Execution default of goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run failed: Cannot read the array length because "<local6>" is null ``` After: ``` $ export SPARK_PROTOC_EXEC_PATH=/Users/foobar/dev/protoc-4.29.1/protoc $ export CONNECT_PLUGIN_EXEC_PATH=/Users/foobar/dev/protoc-gen-grpc-java-1.59.1/protoc-gen-grpc-java $ build/mvn -DskipTests clean install -pl connector/protobuf -e -am ... [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Spark Project Parent POM 4.0.0-SNAPSHOT: [INFO] [INFO] Spark Project Parent POM ........................... SUCCESS [ 10.919 s] [INFO] Spark Project Tags ................................. SUCCESS [ 14.863 s] [INFO] Spark Project Sketch ............................... SUCCESS [ 12.846 s] [INFO] Spark Project Common Utils ......................... SUCCESS [ 40.357 s] [INFO] Spark Project Local DB ............................. SUCCESS [ 15.832 s] [INFO] Spark Project Networking ........................... SUCCESS [ 25.713 s] [INFO] Spark Project Shuffle Streaming Service ............ SUCCESS [ 22.698 s] [INFO] Spark Project Variant .............................. SUCCESS [ 8.609 s] [INFO] Spark Project Unsafe ............................... SUCCESS [ 22.050 s] [INFO] Spark Project Connect Shims ........................ SUCCESS [ 7.508 s] [INFO] Spark Project Launcher ............................. SUCCESS [ 12.242 s] [INFO] Spark Project Core ................................. SUCCESS [04:15 min] [INFO] Spark Project SQL API .............................. SUCCESS [01:11 min] [INFO] Spark Project Catalyst ............................. SUCCESS [05:23 min] [INFO] Spark Project SQL .................................. SUCCESS [08:29 min] [INFO] Spark Protobuf ..................................... SUCCESS [ 53.589 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 23:28 min [INFO] Finished at: 2024-12-26T13:51:59+08:00 [INFO] ------------------------------------------------------------------------ ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Run command: `$ build/mvn -DskipTests clean install -pl connector/protobuf -e -am` ### Was this patch authored or co-authored using generative AI tooling? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
