LuciferYang commented on code in PR #49302:
URL: https://github.com/apache/spark/pull/49302#discussion_r1897895077
##########
dev/checkstyle.xml:
##########
@@ -172,32 +172,10 @@
<property name="format" value="throw new \w+Error\("/>
<property name="message" value="Avoid throwing error in
application code."/>
</module>
- <module name="RegexpSinglelineJava">
- <property name="format" value="Objects\.toStringHelper"/>
- <property name="message" value="Avoid using Object.toStringHelper.
Use ToStringBuilder instead." />
- </module>
<module name="RegexpSinglelineJava">
<property name="format" value="new
(java\.lang\.)?(Byte|Integer|Long|Short)\("/>
<property name="message" value="Use static factory 'valueOf' or
'parseXXX' instead of the deprecated constructors." />
</module>
- <module name="RegexpSinglelineJava">
- <property name="format" value="Files\.createTempDir\("/>
- <property name="message"
- value="Avoid using com.google.common.io.Files.createTempDir()
due to CVE-2020-8908.
Review Comment:
cc @dongjoon-hyun
Do you think we can clean up these check rules now?
Are there any edge cases that I haven't considered?
##########
dev/checkstyle.xml:
##########
@@ -172,32 +172,10 @@
<property name="format" value="throw new \w+Error\("/>
<property name="message" value="Avoid throwing error in
application code."/>
</module>
- <module name="RegexpSinglelineJava">
- <property name="format" value="Objects\.toStringHelper"/>
- <property name="message" value="Avoid using Object.toStringHelper.
Use ToStringBuilder instead." />
- </module>
<module name="RegexpSinglelineJava">
<property name="format" value="new
(java\.lang\.)?(Byte|Integer|Long|Short)\("/>
<property name="message" value="Use static factory 'valueOf' or
'parseXXX' instead of the deprecated constructors." />
</module>
- <module name="RegexpSinglelineJava">
- <property name="format" value="Files\.createTempDir\("/>
- <property name="message"
- value="Avoid using com.google.common.io.Files.createTempDir()
due to CVE-2020-8908.
Review Comment:
cc @dongjoon-hyun
Do you think we can clean up these check rules now?
Are there any edge cases that I haven't considered? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
