cloud-fan commented on code in PR #49202:
URL: https://github.com/apache/spark/pull/49202#discussion_r1898203349
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkOptimizer.scala:
##########
@@ -95,7 +100,11 @@ class SparkOptimizer(
EliminateLimits,
ConstantFolding),
Batch("User Provided Optimizers", fixedPoint,
experimentalMethods.extraOptimizations: _*),
- Batch("Replace CTE with Repartition", Once, ReplaceCTERefWithRepartition)))
+ Batch("Replace CTE with Repartition", Once, ReplaceCTERefWithRepartition),
+ Batch("Merge With expression", fixedPoint, MergeWithExpression),
+ Batch("Rewrite With expression", fixedPoint,
Review Comment:
OK now this makes me a bit worried. One major limitation of `With` is that
we must move it as a whole. Otherwise we have dangling `CommonExpressionRef`.
It seems safer to rewrite `With` immediately at the beginning of the
optimizer and right after the place that we produce new `With`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
