cloud-fan commented on code in PR #49232:
URL: https://github.com/apache/spark/pull/49232#discussion_r1900118646
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala:
##########
@@ -317,9 +404,11 @@ object CTESubstitution extends Rule[LogicalPlan] {
// This cannot be done in ResolveSubquery because ResolveSubquery does
not know the CTE.
other.transformExpressionsWithPruning(_.containsPattern(PLAN_EXPRESSION)) {
case e: SubqueryExpression =>
- e.withNewPlan(apply(substituteCTE(e.plan, alwaysInline,
cteRelations)))
+ e.withNewPlan(
+ apply(substituteCTE(e.plan, alwaysInline, cteRelations, None)))
}
}
+ substituted
Review Comment:
ditto, no need to create the variant `substituted` and return it immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
