Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6394#discussion_r31657904
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -253,10 +269,26 @@ private[yarn] class YarnAllocator(
        * added in recent versions.
        */
       private def createContainerRequest(resource: Resource): ContainerRequest 
= {
    +    // filter nodes which don't have containers but node preference is 
required.
    +    val nodes = {
    +      val unusedNodes = preferredNodeLocationToUses.filterKeys(_ == 
false).keys
    +      if (unusedNodes.isEmpty) {
    +        null
    +      } else {
    +        unusedNodes.toArray
    +      }
    +    }
    +
    +    val racks = if (preferredRackLocations.isEmpty) {
    +      null
    +    } else {
    +      preferredRackLocations.toArray
    +    }
    +
         nodeLabelConstructor.map { constructor =>
    -      constructor.newInstance(resource, null, null, RM_REQUEST_PRIORITY, 
true: java.lang.Boolean,
    +      constructor.newInstance(resource, nodes, racks, RM_REQUEST_PRIORITY, 
true: java.lang.Boolean,
    --- End diff --
    
    Ah, that only applies when relax=false, which we never do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to