siying commented on code in PR #49278:
URL: https://github.com/apache/spark/pull/49278#discussion_r1904736000
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala:
##########
@@ -64,7 +64,8 @@ class IncrementalExecution(
val watermarkPropagator: WatermarkPropagator,
val isFirstBatch: Boolean,
val currentStateStoreCkptId:
- MutableMap[Long, Array[Array[String]]] = MutableMap[Long,
Array[Array[String]]]())
+ Option[MutableMap[Long, Array[Array[String]]]] =
+ Option(MutableMap[Long, Array[Array[String]]]()))
Review Comment:
Is this variable never None? There is no point to make Option in that case.
If we make it Option, perhaps we should do the same as
`MicroBatchExecution.currentStateStoreCkptId`
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CommitLog.scala:
##########
@@ -51,6 +51,8 @@ class CommitLog(sparkSession: SparkSession, path: String)
import CommitLog._
+ private val VERSION = SQLConf.get.stateStoreCheckpointFormatVersion
Review Comment:
Why is it moved here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
