JiexingLi commented on code in PR #49399:
URL: https://github.com/apache/spark/pull/49399#discussion_r1906758958


##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -2387,6 +2387,12 @@
     ],
     "sqlState" : "42604"
   },
+  "INVALID_EXECUTOR_HEARTBEAT_INTERVAL" : {

Review Comment:
   Discussed offline with Bo and Xingbo. By adding a new error class for 
heartbeat config might be too much, as we could have a lot of config 
validations, this way may require us to add many different error classes.
   
   A better way for doing this is by adding a more generic error class, such as 
INVALID_SPARK_CONFIG for SparkConf.validateSettings. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to