pan3793 commented on code in PR #49483:
URL: https://github.com/apache/spark/pull/49483#discussion_r1914532331
##########
connector/profiler/src/main/scala/org/apache/spark/executor/profiler/ExecutorJVMProfiler.scala:
##########
@@ -42,14 +42,15 @@ private[spark] class ExecutorJVMProfiler(conf: SparkConf,
executorId: String) ex
private val profilerLocalDir = conf.get(EXECUTOR_PROFILING_LOCAL_DIR)
private val writeInterval = conf.get(EXECUTOR_PROFILING_WRITE_INTERVAL)
- private val appId = try {
- conf.getAppId
- } catch {
- case _: NoSuchElementException => "local-" + System.currentTimeMillis
+ // app_id and app_attempt_id is unavailable during drvier plugin
initialization
+ private def getAppId: Option[String] = conf.getOption("spark.app.id")
Review Comment:
@parthchandra I hit the app id unavailable issue when adding the driver
plugin support, and fixed it by deferring DFS dir creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
