miland-db commented on code in PR #49485:
URL: https://github.com/apache/spark/pull/49485#discussion_r1915440583
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -2000,6 +2000,21 @@ class SqlScriptingParserSuite extends SparkFunSuite with
SQLHelper {
assert(tree.collection(4).asInstanceOf[ForStatement].label.get == "lbl")
}
+ test("qualified label name: label cannot be qualified") {
Review Comment:
Check for unqualified label name is done inside method that is used in all
label checks, regardless of where label is used (for, while, loop, begin/end
block).
For end label, if it is provided, we test it to be **equal** to the start
label: start label is valid => end label is valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
