aokolnychyi commented on code in PR #49493:
URL: https://github.com/apache/spark/pull/49493#discussion_r1915913273
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ProjectingInternalRow.scala:
##########
@@ -19,16 +19,14 @@ package org.apache.spark.sql.catalyst
import org.apache.spark.SparkUnsupportedOperationException
import org.apache.spark.sql.catalyst.util.{ArrayData, MapData}
-import org.apache.spark.sql.types.{DataType, Decimal, StructType}
+import org.apache.spark.sql.types.{DataType, Decimal}
import org.apache.spark.unsafe.types.{CalendarInterval, UTF8String, VariantVal}
/**
* An [[InternalRow]] that projects particular columns from another
[[InternalRow]] without copying
* the underlying data.
*/
-case class ProjectingInternalRow(schema: StructType,
Review Comment:
When I added this class, I was using `schema` in input validation. That
said, it was a fairly useless check. I had to rework input validation in this
PR and we no longer need `schema` here. This class is internal and only used in
DML.
I generally have no problem keeping it as before but `schema` is kind of
useless now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
