pan3793 commented on code in PR #49480:
URL: https://github.com/apache/spark/pull/49480#discussion_r1916048280
##########
project/SparkBuild.scala:
##########
@@ -65,10 +65,10 @@ object BuildCommons {
).map(ProjectRef(buildLocation, _)) ++ sqlProjects ++ streamingProjects ++
connectProjects
val optionallyEnabledProjects@Seq(kubernetes, yarn,
- sparkGangliaLgpl, streamingKinesisAsl,
+ sparkGangliaLgpl, streamingKinesisAsl, profiler,
Review Comment:
@LuciferYang thanks for the guidance, after some local experiments, I think
we must modify `SparkBuild.scala` to explicitly list the `profiler` module,
otherwise `MimaKeys.mimaFailOnNoPrevious := false` would take effect.
##########
project/SparkBuild.scala:
##########
@@ -65,10 +65,10 @@ object BuildCommons {
).map(ProjectRef(buildLocation, _)) ++ sqlProjects ++ streamingProjects ++
connectProjects
val optionallyEnabledProjects@Seq(kubernetes, yarn,
- sparkGangliaLgpl, streamingKinesisAsl,
+ sparkGangliaLgpl, streamingKinesisAsl, profiler,
Review Comment:
@LuciferYang thanks for the guidance, after some local experiments, I think
we must modify `SparkBuild.scala` to explicitly list the `profiler` module,
otherwise `MimaKeys.mimaFailOnNoPrevious := false` won't take effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
