sunxiaoguang commented on PR #49452: URL: https://github.com/apache/spark/pull/49452#issuecomment-2593063119
> Question: Prior to these changes is there any scenario where some data sources might have returned something, although incorrect ? Is there a chance that someone has adapted to this "wrong" behaviour ? > > Should we protect this change behind a flag ? > > My understanding is that this never produced any kind of results that customers could have adapted to - hence flag is not required. Is this your understanding as well ? > > Also. please lets check that pushdown is happening, to make sure we are testing what we want Yes your understanding is correct. Before this PR, queries using binary literal would generates SQL with invalid binary literal and causes SQL to fail. <img width="1180" alt="image" src="https://github.com/user-attachments/assets/92800c55-5400-46b0-b3f1-d95b85d89cb5"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
