mridulm commented on code in PR #49479:
URL: https://github.com/apache/spark/pull/49479#discussion_r1917048583
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDB.java:
##########
@@ -176,11 +176,13 @@ public void writeAll(List<?> values) throws Exception {
final Iterator<byte[]> serializedValueIter;
// Deserialize outside synchronized block
- List<byte[]> list = new ArrayList<>(entry.getValue().size());
- for (Object value : values) {
- list.add(serializer.serialize(value));
+ {
Review Comment:
You are right, scope change is not strictly required :) I can revert if it
is adding to confusion.
The main change is the `values` -> `entry.getValue()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
