LuciferYang commented on PR #49531: URL: https://github.com/apache/spark/pull/49531#issuecomment-2597486129
It seems that this code path does not have sufficient test coverage. I added a log statement in the `closeAndRead` method and then conducted tests on the `network-shuffle` and `core` modules locally. I found that: 1. The tests in the `network-shuffle` module do not cover this code path; 2.There are a few test cases in the `core` module that indirectly cover this path (such as some test cases in `DistributedSuite`), but it is not easy to add new assertions. So, could you add a targeted test case in this pull request? @ChenMichael Thanks ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
