sunxiaoguang commented on code in PR #49453:
URL: https://github.com/apache/spark/pull/49453#discussion_r1919689690
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala:
##########
@@ -241,6 +241,72 @@ class MySQLIntegrationSuite extends
DockerJDBCIntegrationV2Suite with V2JDBCTest
assert(rows10(0).getString(0) === "amy")
assert(rows10(1).getString(0) === "alex")
}
+
+ test("SPARK-50793: MySQL JDBC Connector failed to cast some types") {
+ val tableName = catalogName + ".test_cast_function"
+ withTable(tableName) {
+ val stringValue = "0"
+ val stringLiteral = "'0'"
+ val longValue = 0L
+ val binaryValue = Array[Byte](0x30)
+ val binaryLiteral = "x'30'"
+ val doubleValue = 0.0
+ val doubleLiteral = "0.0"
+ // CREATE table to use types defined in Spark SQL
+ sql(s"""CREATE TABLE $tableName (
+ string_col STRING,
+ long_col LONG,
+ binary_col BINARY,
+ double_col DOUBLE
+ )""")
+ sql(
+ s"INSERT INTO $tableName VALUES($stringLiteral, $longValue,
$binaryLiteral, $doubleValue)")
+
+ def testCast(castType: String, sourceCol: String, targetCol: String,
+ sourceDataType: DataType, sourceValue: Any,
+ targetDataType: DataType, targetValue: Any): Unit = {
+ val sql =
+ s"""SELECT $sourceCol AS source, CAST($sourceCol AS $castType) AS
target FROM $tableName
+ |WHERE CAST($sourceCol AS $castType) = $targetCol""".stripMargin
+ val df = spark.sql(sql)
+ castType match {
+ case "SHORT" | "INTEGER" =>
+ checkError(
+ exception = intercept[SparkException] {
+ df.collect()
+ },
+ condition = null
+ )
Review Comment:
I put cast in projection, so they are triggered no matter if predicate
pushdown is enabled. I thought this way we are sure the guard actually works no
matter predicate pushdown is enabled or not. In addition, if we don't add the
explicit exception, using cast still fails but just with different root cause
exception during execution time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
