Github user ryan-williams commented on a diff in the pull request:
https://github.com/apache/spark/pull/6624#discussion_r31677556
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -266,10 +266,12 @@ private[spark] class ExecutorAllocationManager(
// executors and inform the cluster manager to cancel the extra
pending requests
val oldNumExecutorsTarget = numExecutorsTarget
numExecutorsTarget = math.max(maxNeeded, minNumExecutors)
- client.requestTotalExecutors(numExecutorsTarget)
- numExecutorsToAdd = 1
- logInfo(s"Lowering target number of executors to $numExecutorsTarget
because " +
- s"not all requests are actually needed (previously
$oldNumExecutorsTarget)")
+ if (numExecutorsTarget < oldNumExecutorsTarget) {
--- End diff --
basically, if the contract is "we start `numExecutorsToAdd` at 1, and every
time we decrease we reset it to 1", then I think we get everything we want, no?
obvs it's a nit to pick, just want to be sure we're all agreed about the
semantics and more importantly that I understand the code I'm modifying :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
