MaxGekk commented on code in PR #49554:
URL: https://github.com/apache/spark/pull/49554#discussion_r1922022551
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -689,7 +699,18 @@ static List<CollationIdentifier> listCollations() {
CollationNames.UTF8_LCASE,
CollationSpecICU.ICU_VERSION
);
- return Arrays.asList(UTF8_BINARY_COLLATION_IDENT,
UTF8_LCASE_COLLATION_IDENT);
+ CollationIdentifier UTF8_BINARY_RTRIM_COLLATION_IDENT = new
CollationIdentifier(
+ PROVIDER_SPARK,
+ CollationNames.UTF8_BINARY + "_RTRIM",
+ CollationSpecICU.ICU_VERSION
+ );
+ CollationIdentifier UTF8_LCASE_RTRIM_COLLATION_IDENT = new
CollationIdentifier(
+ PROVIDER_SPARK,
+ CollationNames.UTF8_LCASE + "_RTRIM",
+ CollationSpecICU.ICU_VERSION
+ );
+ return Arrays.asList(UTF8_BINARY_COLLATION_IDENT,
UTF8_LCASE_COLLATION_IDENT,
+ UTF8_BINARY_RTRIM_COLLATION_IDENT,
UTF8_LCASE_RTRIM_COLLATION_IDENT);
Review Comment:
fix indentation. this is even inconsistent to other parts of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
