harshmotw-db opened a new pull request, #49591:
URL: https://github.com/apache/spark/pull/49591
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Prior to this PR, if the top level data in createDataFrame is of type
`VariantVal`, it succeeded and created a dataframe with nulls in each row. This
PR causes `createDataFrame([<VariantVal>], "v variant")` to fail.
### Why are the changes needed?
`createDataFrame([<VariantVal>], "v variant")` doesn't make sense. The data
should be similar to `Iterable[Row]`. Since `VariantVal` is a relatively new
data type and creating `VariantVal`'s before the [parseJson
implementation](https://github.com/apache/spark/pull/49450) which is very
recent was infeasible, this behavioral change should be acceptable.
### Does this PR introduce _any_ user-facing change?
Yes, users could run `createDataFrame([<VariantVal>], "v variant")` before
(but only got a dataframe containing nulls) and they can no longer do that.
### How was this patch tested?
Unit test
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
