zhengruifeng commented on code in PR #49601:
URL: https://github.com/apache/spark/pull/49601#discussion_r1925372177
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/ml/MLHelper.scala:
##########
@@ -298,7 +299,7 @@ class MyLogisticRegressionModel(
override val uid: String,
val intercept: Float,
val coefficients: Float)
- extends Model[MyLogisticRegressionModel]
+ extends ClassificationModel[Double, MyLogisticRegressionModel]
Review Comment:
it failed with
```
- ML backend: model works *** FAILED *** (350 milliseconds)
[info] org.apache.spark.sql.connect.ml.MLAttributeNotAllowedException:
[CONNECT_ML.ATTRIBUTE_NOT_ALLOWED] Generic Spark Connect ML error. predictRaw
is not allowed to be accessed. SQLSTATE: XX000
```
because `Model` does not have `predictRaw`, it should be a
`ClassificationModel`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
