cloud-fan commented on code in PR #49609: URL: https://github.com/apache/spark/pull/49609#discussion_r1926271280
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala: ########## @@ -265,10 +258,16 @@ case class VariantGet( override lazy val dataType: DataType = targetType.asNullable + private lazy val pathIsFoldable: Boolean = path.foldable Review Comment: `path.foldable` is very cheap and we don't need a lazy val to cache it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
